refactor(store): optimize Schema #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bade5cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
great work! |
dk1a
commented
Aug 9, 2023
Comment on lines
315
to
+330
| "file": "test/Schema.t.sol", | ||
| "test": "testGetNumDynamicFields", | ||
| "name": "get number of dynamic fields from schema", | ||
| "gasUsed": 74 | ||
| "gasUsed": 68 | ||
| }, | ||
| { | ||
| "file": "test/Schema.t.sol", | ||
| "test": "testGetNumFields", | ||
| "name": "get number of all fields from schema", | ||
| "gasUsed": 34 | ||
| }, | ||
| { | ||
| "file": "test/Schema.t.sol", | ||
| "test": "testGetNumStaticFields", | ||
| "name": "get number of static fields from schema", | ||
| "gasUsed": 85 | ||
| "gasUsed": 79 |
There was a problem hiding this comment.
you may note that getting both dynamic and static is 2x cheaper than getting them separately. This is wrong and related to #1267
I wonder if these tests should be removed to avoid confusion?
15 tasks
holic
previously approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate- only did a few obvious tweaks there)encodecan still be made much better by replacingSchemaTypewith a static length, but that's another PRencodeoptimization would be to inline it in table libs, but not sure it's worth it, will think about it when I get to table libsCase study of
encode's gas optimizations, this function is particularly interesting. (the screenshot shows code before this PR, changes are mostly 1:1, but within the loop I use gas per average iteration, which depends on Schema composition, and I used somewhat different schemas before and after, expect it to vary by 5-10 gas. 56->47 could be mostly noise for example.)Note that gas within the loop is more impactful, as it's multiplied by the number of schema fields.