-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): indexed tableId
in store events
#1520
Conversation
🦋 Changeset detectedLatest commit: 97c1f3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
23cb5e4
to
592500b
Compare
packages/store/gas-report.json
Outdated
}, | ||
{ | ||
"file": "test/StoreCoreDynamic.t.sol", | ||
"test": "testPopFromSecondField", | ||
"name": "pop from field (warm, 1 slot, 1 uint32 item)", | ||
"gasUsed": 15405 | ||
"gasUsed": 16244 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why this would add so much gas here when other operations are like +100 gas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like it adds around 900 gas for operations where we emit an event, while the other methods are getters (why does it even increase gas for getters at all 🤔)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the gas for getters is just the usual sway we see between gas reports for some unexplained reason (optimizer differences when bytecode changes maybe?)
gonna revert, 900 per write seems to high for a "maybe nice"
This reverts commit 592500b.
5f695a1
to
99e493b
Compare
5fd1d67
to
f5b3dce
Compare
tableId
in store events
closes #1127