fix: allow overriding preset components, replace Owned interface with IERC173, fix IComponent interface #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrs
reviewed
Nov 11, 2022
| @@ -3,7 +3,7 @@ pragma solidity >=0.8.0; | |||
| import "solecs/BareComponent.sol"; | |||
|
|
|||
| struct FunctionSelector { | |||
| address contr; | |||
| address target; | |||
There was a problem hiding this comment.
what's the reason for this change?
dk1a
force-pushed
the
dk1a/inheritance
branch
from
1468b84
to
aae7c0e
Compare
|
Yeah that shouldn't be there, removed the struct changes |
alvrs
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
…d interface with IERC173, fix IComponent interface (#239) * refactor(std-contracts): better inheritance for component presets * feat(solecs): use IERC173 instead of IOwned, update IComponent Co-authored-by: alvarius <89248902+alvrs@users.noreply.github.com>
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
… IERC173, fix IComponent interface (latticexyz#239) * refactor(std-contracts): better inheritance for component presets * feat(solecs): use IERC173 instead of IOwned, update IComponent Co-authored-by: alvarius <89248902+alvrs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding component presets in std-contracts
Standardize IComponent and ISystem under IERC173
(Components are effectively unchanged, Systems now get transferOwnership, and transferOwnership also emits an event)
Move getSchema and registerIndexer into IComponent, fix some comments