Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use nodejs grpc transport #374

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix(cli): use nodejs grpc transport #374

merged 1 commit into from
Feb 7, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Feb 6, 2023

No description provided.

@holic holic self-assigned this Feb 6, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to fix it for me!

To test it, I synced mud locally from main, ran the faucet command, and saw the error

Error: This environment's XHR implementation cannot support binary transfer.
    at /Users/kevin/Projects/latticexyz/mud/packages/cli/dist/commands/faucet.js:3391:19

then did the same for this branch and the faucet request went through!

@alvrs alvrs merged commit 4c9ca7d into main Feb 7, 2023
@holic holic mentioned this pull request Feb 7, 2023
@alvrs alvrs deleted the alvrs/faucet-cli branch May 18, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants