Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev-tools): various UX improvements #887

Merged
merged 4 commits into from
May 18, 2023
Merged

fix(dev-tools): various UX improvements #887

merged 4 commits into from
May 18, 2023

Conversation

holic
Copy link
Member

@holic holic commented May 18, 2023

related to #777

  • returns unmount function from mount (inside an optional promise though, which isn't great)
  • prevents mounting more than once
  • attempts to fix layering (not sure why stacking contexts didn't help here)
  • adjusts show/hide button colors to better suit both dark and light backgrounds
  • keeps track of open/close state in localStorage (and consistent between browser tabs)

@holic holic marked this pull request as ready for review May 18, 2023 01:06
@holic holic requested a review from alvrs as a code owner May 18, 2023 01:06
@holic holic merged commit 2fc44a6 into main May 18, 2023
@holic holic deleted the holic/dev-tools-ux-fix branch May 18, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@holic