fix(network): fix dynamic data warning #888
Merged
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holic
force-pushed
the
holic/dynamic-data-warning
branch
from
4302c25
to
91c8ba2
Compare
holic
force-pushed
the
holic/dynamic-data-warning
branch
from
91c8ba2
to
21dea08
Compare
holic
force-pushed
the
holic/dynamic-data-warning
branch
from
21dea08
to
99b1107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these warnings:
When we moved PackedCounter's byte lengths in #804, the accumulator became a
bigintin JS, but I didn't account for that originally when incrementing the byte offset and checking if lengths match.This is a quick fix that just casts the number to
bigintfor now, but long term we should probably move tobigints for this value if it has the potential to exceed the max value ofnumber.This mostly wasn't discovered by TS because
decodeStaticFieldanddecodeDynamicFielddon't return the primitive type that corresponds to the passed in schema type. Hoping to refactor this in the future and fix this.