New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: render posix paths for solc #918

Merged

alvrs merged 1 commit into main from alvrs/solpath

May 19, 2023

Member

alvrs commented May 19, 2023 •

edited

Loading

fixes latticexyz/emojimon#11

Explicitly normalize a paths use a poxis separator (/) for when codegenerating solidity files, because solc expects posix paths but path.join uses the win32 separator (\) if the user is on windows.
Followup to fix(store): replace windows path separator with posix path separator #854 (we missed a path, this PR changes the location of normalization to the util rendering imports)


          fix: render posix paths for solc

a83bbd5

alvrs requested a review from holic as a code owner

May 19, 2023 10:46

alvrs requested a review from dk1a

May 19, 2023 10:51

alvrs merged commit ffc66e7 into main

alvrs deleted the alvrs/solpath branch

May 19, 2023 15:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet