Tzdata polling for update

[dowusu]

I observe the below error in my production logs.

[error] GenServer :tzdata_release_updater terminating
** (ArgumentError) argument error
(stdlib) :ets.lookup_element(:hackney_config, :mod_metrics, 2)
/Users/kodepet/Documents/Work/topup/deps/hackney/src/hackney_metrics.erl:26: :hackney_metrics.get_engine/0
/Users/kodepet/Documents/Work/topup/deps/hackney/src/hackney_connect.erl:78: :hackney_connect.create_connection/5
/Users/kodepet/Documents/Work/topup/deps/hackney/src/hackney_connect.erl:47: :hackney_connect.connect/5
/Users/kodepet/Documents/Work/topup/deps/hackney/src/hackney.erl:333: :hackney.request/5
(tzdata) lib/tzdata/http_client/hackney.ex:17: Tzdata.HTTPClient.Hackney.head/3
(tzdata) lib/tzdata/data_loader.ex:46: Tzdata.DataLoader.last_modified_of_latest_available/1
(tzdata) lib/tzdata/release_updater.ex:81: Tzdata.ReleaseUpdater.loaded_tzdata_matches_remote_last_modified?/0
(tzdata) lib/tzdata/release_updater.ex:42: Tzdata.ReleaseUpdater.poll_for_update/0
(tzdata) lib/tzdata/release_updater.ex:19: Tzdata.ReleaseUpdater.handle_info/2
(stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
(stdlib) gen_server.erl:711: :gen_server.handle_msg/6
(stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Last message: :check_if_time_to_update
State: []

[ericmj]

@lau The bug seems to have been introduce in a faulty merge commit. Hackney should be an optional dependency: ac50d19#diff-6023be6004fce4718dad3dafb576d258R34

[dowusu]

I disabled automatic update - I'm fine now, Kudos for the awesome work.

[lau]

@dowusu Thank you. Which version of Elixir did this happen on?

@ericmj Hackney has never been an optional dependency in any releases. Early versions did not have it as a dependency at all though. Even if it were optional, if someone used it and has automatic updating turned on, wouldn't the same thing happen?

It looks to me like a problem with Hackney assuming an ETS table is available - but it is not. Maybe Hackney is not running even though it should be.

I am working on a new version of Tzdata that will not depend on hackney.

[ericmj]

If it's not optional you should not have a custom applications function: https://github.com/lau/tzdata/blob/master/mix.exs#L29-L30.

[lau]

@ericmj Thank you Eric!

[asummers]

That's fixed in #92 I believe!

[dowusu]

@dowusu Thank you. Which version of Elixir did this happen on?

@ericmj Hackney has never been an optional dependency in any releases. Early versions did not have it as a dependency at all though. Even if it were optional, if someone used it and has automatic updating turned on, wouldn't the same thing happen?

It looks to me like a problem with Hackney assuming an ETS table is available - but it is not. Maybe Hackney is not running even though it should be.

I am working on a new version of Tzdata that will not depend on hackney.

[dowusu]

Sorry for the late response, I'm using elixir 1.9.2
I fixed the issue by disabling automatic update.

[lau]

There is a new release 1.0.3 which should fix this.