Repos initialized with git-svn break the app

[appden]

It only loads this far: http://d.pr/I79X

[quimrodri]

Same problem here with 0.8.0. I've tried with 0.8.1 and now it crashes. With a non git-svn repo it works as expected.

Crash report: http://pastebin.com/w1EPfsF0

[jasonrm]

By commenting out the following I'm able to compile 0.8.1 and it works with a git-svn init'ed repo. Not sure what else it breaks as I haven't had time to track down why it was an issue.

--- a/PBGitSidebarController.m
+++ b/PBGitSidebarController.m
@@ -171,7 +171,7 @@ - (void) observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(
  -(void)evaluateRemoteBadge:(PBGitSVRemoteItem *)remote
  {
         NSLog(@"remote.title=%@",[remote title]);
-       [remote setAlert:[self remoteNeedFetch:[remote title]]];
+//     [remote setAlert:[self remoteNeedFetch:[remote title]]];
  }

[jralls]

The state of thread 1 turns out to be a distraction; the crash is actually due to an unhandled exception in thread 4, from calling an unknown method "setAction" on PBGitSVRemoteItem.

This patch corrects the error:

  diff --git a/PBGitSidebarController.m b/PBGitSidebarController.m
  index a9a936e..992080d 100644
  --- a/PBGitSidebarController.m
  +++ b/PBGitSidebarController.m
  @@ -171,7 +171,7 @@ - (void) observeValueForKeyPath:(NSString *)keyPathofObject
   -(void)evaluateRemoteBadge:(PBGitSVRemoteItem *)remote
   {
          NSLog(@"remote.title=%@",[remote title]);
  -       [remote setAlert:[self remoteNeedFetch:[remote title]]];
  +       [remote setTitle:[self remoteNeedFetch:[remote title]]];
   }

   -(NSNumber *)countCommintsOf:(NSString *)range

[laullon]

Problem found... I'll solvet it soon...
This is a temp patch

diff --git a/PBGitSidebarController.m b/PBGitSidebarController.m
index a9a936e..41b33e1 100644
--- a/PBGitSidebarController.m
+++ b/PBGitSidebarController.m
@@ -170,8 +170,10 @@ - (void) observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(

 -(void)evaluateRemoteBadge:(PBGitSVRemoteItem *)remote
 {
-       NSLog(@"remote.title=%@",[remote title]);
-       [remote setAlert:[self remoteNeedFetch:[remote title]]];
+       NSLog(@"remote.title=%@ (%@)",[remote title],remote);
+    if([remote isKindOfClass:[PBGitSVRemoteItem class]]){
+        [remote setAlert:[self remoteNeedFetch:[remote title]]];
+    }
 }

[alexwall]

Nice but why you didn't apply it to the master branch?

[laullon]

not yet...

[alexwall]

Ok

PS: thx for your engagement

[jralls]

No, scratch that: It masks the error, which isn't that PBGitSVRemoteItem doesn't have a setItem method, it's that the pointer that's being passed in is a PVGitSVOtherItem, which doesn't.

The following patch is a workaround, but it's still not clear to me from whence the bad object is coming.
diff --git a/PBGitSidebarController.m b/PBGitSidebarController.m
index 992080d..48a0a63 100644
--- a/PBGitSidebarController.m
+++ b/PBGitSidebarController.m
@@ -171,7 +171,12 @@ - (void) observeValueForKeyPath:(NSString *)keyPath ofObjec
-(void)evaluateRemoteBadge:(PBGitSVRemoteItem *)remote
{
NSLog(@"remote.title=%@",[remote title]);
- [remote setTitle:[self remoteNeedFetch:[remote title]]];
+ if ([remote isMemberOfClass:[PBGitSVRemoteItem class]]) {
+ [remote setAlert:[self remoteNeedFetch:[remote title]]];
+ }
+ else {
+ NSLog(@"evaluateRemoteBadge called with object of wrong type.");
+ }
}

   -(NSNumber *)countCommintsOf:(NSString *)range

[laullon]

solved on 0.8.2

[laullon]

V0.8.2 beta is out http://gitx.posterous.com/gitx-l-v082-beta