Updates Quick to version 3.1.2 #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yammada thanks for the contribution. We will review internally and get back to you. |
|
Hi @yammada, Thanks for putting up this PR! This issue has been fixed in the 5.4.2 release. Too avoid conflicts due to other changes, I didn't merge this PR directly, but we appreciate the contribution. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Quick/Quick#1046
Describe the solution you've provided
Updates Quick to the latest release which addresses build warnings from newer version of Xcode.
Describe alternatives you've considered
None considered.
Additional context
I did not evaluate other dependencies which might need updating. This is currently the only one that produces a top level warning when the SDK is imported into a project.