Fixing crashes when using overflowing values #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
I didn't create a GitHub issue for this, but happy to if necessary.
Describe the solution you've provided
Int(exactly:)
will return nil in case of an overflow whereasInt(_:)
will just crash. When converting theDouble
to anInt
, if it fails, we now useInt.max
as a rescue.Describe alternatives you've considered
Fixing the crash was I think necessary. That being said, we only noticed that crash because we wanted to disable updates to our feature flags during a user session (we want to have a consistent experience throughout the session). There's no way that I could find to do that right now, so we opted for having a really long update interval.
Adding this feature would have been nice too, but was more work that I intended.
Additional context
Nothing else from me.