-
Notifications
You must be signed in to change notification settings - Fork 30
feat: add new Vercel example #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request has been linked to Shortcut Story #204542: Update documentation based on Vercel's feedback. |
}, | ||
plugins: ['@typescript-eslint', 'prettier'], | ||
ignorePatterns: ['**/dist/**'], | ||
ignorePatterns: ['**/dist/**', '**/vercel/examples/**'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't figure out how to get eslint to play nicely with the eslintrc
file in the complete example so I decided to just ignore it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! It really shows off some cool use-cases and looks super easy to set up.
I think the names are fine, have a couple of minor copy things again, but really just excited about it.
packages/sdk/vercel/examples/complete/components/launchdarklyProvider.tsx
Outdated
Show resolved
Hide resolved
🤖 I have created a release *beep* *boop* --- <details><summary>vercel-server-sdk: 0.4.0</summary> ## [0.4.0](vercel-server-sdk-v0.3.0...vercel-server-sdk-v0.4.0) (2023-06-02) ### Features * add new Vercel example ([#130](#130)) ([d25f327](d25f327)) * update Vercel example ([#129](#129)) ([2296c4f](2296c4f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Henry Barrow <hbarrow@launchdarkly.com>
This PR adds a new Vercel example that showcases the following:
app/layout.tsx
andcomponents/launchdarklyProvider.tsx
.middleware.ts
.I'm open to suggestions on new names for the examples.