fix: Export PersistentDataStoreWrapper. #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Jun 7, 2023
| @@ -86,8 +86,6 @@ function deserialize( | |||
| * instance of {@link PersistentDataStore}. It provides optional caching behavior and other logic | |||
| * that would otherwise be repeated in every data store implementation. This makes it easier to | |||
| * create new database integrations by implementing only the database-specific logic. | |||
| * | |||
| * @internal | |||
There was a problem hiding this comment.
Needs to be used by persistent store packages.
kinyoklion
commented
Jun 7, 2023
| @@ -22,12 +22,13 @@ export default class UpdateQueue { | |||
| // count could hit 0, and overlapping execution chains could be started. | |||
| this.queue.shift(); | |||
| // There is more work to do, so schedule an update. | |||
| if (this.enqueue.length > 0) { | |||
There was a problem hiding this comment.
This was a bug, enqueue is a function. The function has 2 parameters, so its length is 2. Which caused the queue to always trigger a task update.
This caused multiple execution of tasks, as well as failing to dispatch other tasks.
kinyoklion
commented
Jun 7, 2023
| import { deserializePoll } from './serialization'; | ||
|
|
||
| export { AsyncStoreFacade, deserializePoll }; | ||
| export { AsyncStoreFacade, PersistentDataStoreWrapper, deserializePoll }; |
There was a problem hiding this comment.
Exporting to be used in persistent store packages.
louis-launchdarkly
approved these changes
Jun 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix a bug in the UpdateQueue, used for persistence, which would prevent tasks from executing correctly.
fix: Update package.json to use --topological-dev when building workspaces. This will ensure packages which have devDependencies on each other, are built in correct order. Currently only "dependencies" affect build order. This will affect store packages because they use a peer+dev dependency on the SDK they are associated with.