Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with TypeScript 4.x #345

Closed
ismaelgt opened this issue Jan 11, 2024 · 1 comment
Closed

Improve compatibility with TypeScript 4.x #345

ismaelgt opened this issue Jan 11, 2024 · 1 comment
Labels
feature Label for feature requests package: shared/common Label for issues affecting the shared/common package.

Comments

@ismaelgt
Copy link
Contributor

ismaelgt commented Jan 11, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Due to the usage of type modifiers on import names, the package can't be compiled as a dependency on projects using TypeScript <4.5.

Describe the solution you'd like

Remove the usage of type modifiers on import names to improve backwards compatibility with early versions of TypeScript.

Describe alternatives you've considered

The obvious solution would be upgrading the TypeScript version in the consumer, but this is not always easy (it's not in our case). More info here.
@ismaelgt ismaelgt added feature Label for feature requests package: shared/common Label for issues affecting the shared/common package. labels Jan 11, 2024
ismaelgt added a commit to ismaelgt/launchdarkly-js-core that referenced this issue Jan 11, 2024
@ismaelgt
fix: remove type modifiers on imports for better TS compatibility (la…
b0aba61 
…unchdarkly#345)
This was referenced Jan 11, 2024
Merged
Closed
kinyoklion pushed a commit that referenced this issue Jan 16, 2024
@ismaelgt
fix: remove type modifiers on imports for better TS compatibility (#346)
3506349 
**Requirements**

- [ ] ~I have added test coverage for new or changed functionality~
- [x] I have followed the repository's [pull request submission
guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
- [ ] ~I have validated my changes against all supported platform
versions~

No new functionality has been added (only types import/export
refactoring).

**Related issues**

#345
#347

**Describe the solution you've provided**

Remove the usage of [type modifiers on import
names](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#type-modifiers-on-import-names)
to improve backwards compatibility with early versions of TypeScript.

**Describe alternatives you've considered**

The obvious solution would be upgrading the TypeScript version in the
consumer, but this is not always easy (it's not in our case). [More info
here](microsoft/TypeScript#25778).
@ismaelgt
Copy link
Contributor Author

This is now fixed.

@filmaj filmaj mentioned this issue Jul 4, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Label for feature requests package: shared/common Label for issues affecting the shared/common package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ismaelgt