feat: Implement handling for gzip compressed responses. #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #231032: Support compression for Node. |
|
I will be holding off on merging this until we are sure of the testing strategy. |
kinyoklion
requested review from
yusinto and
louis-launchdarkly
as code owners
Is it possible to add unit tests at least please? |
There are unit tests now. |
yusinto
approved these changes
Feb 12, 2024
Merged
kinyoklion
added a commit
that referenced
this pull request
Feb 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>node-server-sdk: 9.2.0</summary> ## [9.2.0](node-server-sdk-v9.1.1...node-server-sdk-v9.2.0) (2024-02-14) ### Features * Implement handling for gzip compressed responses. ([#367](#367)) ([a52bee1](a52bee1)) </details> <details><summary>node-server-sdk-dynamodb: 6.1.2</summary> ## [6.1.2](node-server-sdk-dynamodb-v6.1.1...node-server-sdk-dynamodb-v6.1.2) (2024-02-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.1.1 to 9.2.0 * peerDependencies * @launchdarkly/node-server-sdk bumped from 9.1.1 to 9.2.0 </details> <details><summary>node-server-sdk-redis: 4.1.2</summary> ## [4.1.2](node-server-sdk-redis-v4.1.1...node-server-sdk-redis-v4.1.2) (2024-02-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.1.1 to 9.2.0 * peerDependencies * @launchdarkly/node-server-sdk bumped from 9.1.1 to 9.2.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working against the test harness and LD.