-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to set custom storage #436
Labels
enhancement
New feature or request
feature
Label for feature requests
package: sdk/react-native
Issues that affect the react native SDK.
Stale
Comments
artyorsh
added
feature
Label for feature requests
package: shared/common
Label for issues affecting the shared/common package.
labels
Apr 12, 2024
We will investigate this. Internally logged 240413. |
+1 on this, we try to use mmkv for everything |
kinyoklion
added
package: sdk/react-native
Issues that affect the react native SDK.
and removed
package: shared/common
Label for issues affecting the shared/common package.
labels
Apr 23, 2024
This issue is stale because it has been open for 90 days without activity. Remove the stale label or comment, or this will be closed in 14 days. |
kinyoklion
added a commit
that referenced
this issue
Aug 27, 2024
This PR fixes #436 by implementing a custom storage option to the React Native package. The main motivation is to get rid of the obsolete async storage package, but we also found that having multiple clients as [recommended by the official docs](https://docs.launchdarkly.com/sdk/features/multiple-environments#react-native) when migrating away from `secondaryMobileKeys` in v9 caused them to overwrite each other's storage and therefore effectively disabling the storage/cache altogether. --------- Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
feature
Label for feature requests
package: sdk/react-native
Issues that affect the react native SDK.
Stale
Is your feature request related to a problem? Please describe.
In react-native, the SDK uses
@react-native-async-storage/async-storage
package without an option to specify a custom destination for SDK keys. This mixes app-related keys with SDK keys, which is especially painful when migrating to a different library (say, MMKV). This also blocks apps from removing async-storage dependency.Describe the solution you'd like
Describe alternatives you've considered
Providing a documentation on what keys are stored by SDK would also work, giving an option to filter async-storage.
The text was updated successfully, but these errors were encountered: