fix: Ensure browser contract tests run during top-level build. #589
+9
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Sep 23, 2024
| "description": "Contract test service implementation for @launchdarkly/js-client-sdk", | ||
| "scripts": { | ||
| "start": "vite --open=true", | ||
| "build": "tsc --noEmit && vite build", |
There was a problem hiding this comment.
There wasn't a build command, so it didn't run with the root build.
kinyoklion
commented
Sep 23, 2024
There was a problem hiding this comment.
I forgot to update this when I removed AutoEnvAttributes.
kinyoklion
commented
Sep 23, 2024
| "description": "Contract test service implementation for @launchdarkly/js-client-sdk", | ||
| "scripts": { | ||
| "start": "vite --open=true", | ||
| "start": "tsc --noEmit && vite --open=true", |
There was a problem hiding this comment.
Make sure the typescript it valid when running the dev server.
kinyoklion
commented
Sep 23, 2024
| }; | ||
| } | ||
|
|
||
| cf.fetchGoals = false; |
There was a problem hiding this comment.
Don't fetch goals. It confuses the test harness.
kinyoklion
commented
Sep 23, 2024
|
|
||
| override async identify(context: LDContext): Promise<void> { | ||
| await super.identify(context); | ||
| override async identify(context: LDContext, identifyOptions?: LDIdentifyOptions): Promise<void> { |
There was a problem hiding this comment.
I missed this, which doesn't make the SDK not work, but does cause problems for the test harness.
tanderson-ld
approved these changes
Sep 23, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk: 0.0.1</summary> ## 0.0.1 (2024-10-10) ### Features * Add basic secure mode support for browser SDK. ([#598](#598)) ([3389983](3389983)) * Add bootstrap support. ([#600](#600)) ([4e5dbee](4e5dbee)) * Add browser info. ([#576](#576)) ([a2f4398](a2f4398)) * Add ESM support for common and common-client (rollup) ([#604](#604)) ([8cd0cdc](8cd0cdc)) * Add support for browser contract tests. ([#582](#582)) ([38f081e](38f081e)) * Add support for hooks. ([#605](#605)) ([04d347b](04d347b)) * Add support for js-client-sdk style initialization. ([53f5bb8](53f5bb8)) * Add support for localStorage for the browser platform. ([#566](#566)) ([4792391](4792391)) * Add URLs for custom events and URL filtering. ([#587](#587)) ([7131e69](7131e69)) * Add visibility handling to allow proactive event flushing. ([#607](#607)) ([819a311](819a311)) * adds datasource status to sdk-client ([#590](#590)) ([6f26204](6f26204)) * Adds support for REPORT. ([#575](#575)) ([916b724](916b724)) * Browser-SDK Automatically start streaming based on event handlers. ([#592](#592)) ([f2e5cbf](f2e5cbf)) * Implement browser crypto and encoding. ([#574](#574)) ([e763e5d](e763e5d)) * Implement goals for client-side SDKs. ([#585](#585)) ([fd38a8f](fd38a8f)) * Implement support for browser requests. ([#578](#578)) ([887548a](887548a)) * Refactor data source connection handling. ([53f5bb8](53f5bb8)) * Scaffold browser client. ([#579](#579)) ([0848ab7](0848ab7)) ### Bug Fixes * Ensure browser contract tests run during top-level build. ([#589](#589)) ([7dfb14d](7dfb14d)) * Ensure client logger is always wrapped in a safe logger. ([#599](#599)) ([980e4da](980e4da)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.