fix: Consolidate common exports between base package and compat package. #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
kinyoklion
force-pushed
the
rlamb/common-browser-exports
branch
2 times, most recently
from
364b25d to
35de0b2
Compare
kinyoklion
force-pushed
the
rlamb/common-browser-exports
branch
from
35de0b2 to
a74e827
Compare
tanderson-ld
approved these changes
Nov 8, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Nov 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk: 0.3.1</summary> ## [0.3.1](js-client-sdk-v0.3.0...js-client-sdk-v0.3.1) (2024-11-08) ### Bug Fixes * Consolidate common exports between base package and compat package. ([#674](#674)) ([f692050](f692050)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was proving difficult to ensure that the compat package and the base package exported all the common stuff. So I moved that stuff into a common files and then export that from both.