feat: create sdk-server-edge package #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Removed redundant createLDClient function.
…package to use that.
|
This pull request has been linked to Shortcut Story #197407: Refactor common edge function code. |
yusinto
commented
Apr 17, 2023
yusinto
commented
Apr 17, 2023
| "files": [ | ||
| "/dist" | ||
| ], | ||
| "scripts": { | ||
| "doc": "../../../scripts/build-doc.sh .", |
There was a problem hiding this comment.
This is useful for local dev.
yusinto
commented
Apr 17, 2023
yusinto
commented
Apr 17, 2023
yusinto
commented
Apr 17, 2023
kinyoklion
reviewed
Apr 17, 2023
kinyoklion
reviewed
Apr 17, 2023
| @@ -0,0 +1,3 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
I probably need to write a document, but when we make the first release you will have to manually edit this file, because release-please will put the release note before this notice. But once you move it to the correct place all future releases will be correct. This is just a note, note a request to change anything.
yusinto
commented
Apr 17, 2023
kinyoklion
approved these changes
Apr 17, 2023
Merged
kinyoklion
approved these changes
Apr 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable sharing of common code between cloudflare and vercel, this PR:
Remaining tasks which will be covered in separate PRs:
This PR should unblock the vercel team with their work. The vercel sdk should follow the cloudflare sdk requiring only the implementation featureStore and platformInfo objects.