-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Scaffold jest mock project. #483
chore: Scaffold jest mock project. #483
Conversation
@@ -0,0 +1,3 @@ | |||
# Changelog | |||
|
|||
All notable changes to the LaunchDarkly Jest package will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a continuation of the existing library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not. It will be a new library published under @launchdarkly/jest
and initially only supports react-native mocks. Subsequently it should only support mocks for new major versions of the react and js sdks under js-core.
Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
# HACK: jest is not ready for release yet. | ||
if: false #${{ needs.release-please.outputs.package-tooling-jest-release == 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kinyoklion this should stop auto-release. Manual publish is still active, but I think that's ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will prevent publishing packages, but will still make release PRs with changelog entries and things. Which is fine so long as you are ok with the tags and things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok ta. I've also rolled back release-please-config.json
.
As part of the mentorship program, @professorice and I have been working on the react-native mock library. This PR is to scaffold the jest mock library in js-core, so we can work on the react-native mock library and also other jest mocks in the future.
# The new jest package lives here packages/tooling/jest