Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move closure routes to controller methods to allow caching routes #42

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@alextime
Copy link
Contributor

commented Feb 13, 2019

No description provided.

@walidbagh

This comment has been minimized.

Copy link

commented Feb 13, 2019

Seems correct.

@mikemand

This comment has been minimized.

Copy link

commented Feb 13, 2019

You could make these Invokable controllers since they only do one action each.

@akazorg akazorg merged commit ca6f1e8 into launcher-host:master Feb 14, 2019

0 of 2 checks passed

continuous-integration/styleci/pr Issues have been identified with 2 files
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@akazorg

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Thanks for the PR @alextime!
@mikemand nice catch, invokable controllers looks great. Please fell free to submit PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.