Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move closure routes to controller methods to allow caching routes #42

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Move closure routes to controller methods to allow caching routes #42

merged 1 commit into from
Feb 14, 2019

Conversation

alextime
Copy link
Contributor

No description provided.

@walidbagh
Copy link

Seems correct.

@mikemand
Copy link

You could make these Invokable controllers since they only do one action each.

@akazorg akazorg merged commit ca6f1e8 into launcher-host:master Feb 14, 2019
@akazorg
Copy link
Member

akazorg commented Feb 14, 2019

Thanks for the PR @alextime!
@mikemand nice catch, invokable controllers looks great. Please fell free to submit PR for that.

@akazorg akazorg mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alextime @walidbagh @mikemand @akazorg