Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate all pulumi usage to use component resources #244

Merged
merged 9 commits into from
Aug 8, 2023

Conversation

boetro
Copy link
Collaborator

@boetro boetro commented Aug 7, 2023

No description provided.

@boetro boetro requested a review from JoshTanke as a code owner August 7, 2023 23:10
@boetro boetro changed the base branch from flowstate to main August 8, 2023 14:40
@boetro boetro changed the title checkpoint on pulumi resource changes migrate all pulumi usage to use component resources Aug 8, 2023
@boetro boetro closed this Aug 8, 2023
@boetro boetro reopened this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 84.38% and project coverage change: +0.88% 🎉

Comparison is base (0b616bb) 78.72% compared to head (5989013) 79.61%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   78.72%   79.61%   +0.88%     
==========================================
  Files         103      144      +41     
  Lines        3648     5140    +1492     
==========================================
+ Hits         2872     4092    +1220     
- Misses        776     1048     +272     
Files Changed Coverage Δ
buildflow/core/app/infra/_infra.py 100.00% <ø> (ø)
buildflow/core/app/runtime/_runtime.py 100.00% <ø> (ø)
buildflow/core/options/flow_options.py 100.00% <ø> (ø)
buildflow/core/types/portable_types.py 100.00% <ø> (ø)
buildflow/core/utils.py 75.67% <ø> (ø)
buildflow/io/strategies/_strategy.py 100.00% <ø> (ø)
...ntime/actors/pipeline_pattern/pull_process_push.py 20.52% <11.11%> (-0.85%) ⬇️
buildflow/core/app/runtime/actors/process_pool.py 36.00% <20.00%> (-4.23%) ⬇️
...ake/background_tasks/table_load_background_task.py 31.20% <31.20%> (ø)
...s/providers/s3_file_change_stream_provider_test.py 34.37% <34.37%> (ø)
... and 114 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boetro boetro merged commit 344a688 into launchflow:main Aug 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants