Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 CreateStmt with tableElts #4

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

fljdin
Copy link
Contributor

@fljdin fljdin commented Jun 7, 2022

Closes #3

@pyramation could you explain me how to:

  • rebuild sql/ast--*.sql from deploy files?
  • write a unit test with your framework?

@pyramation
Copy link
Collaborator

wow this looks great!

I can do it if it's too much trouble, but the way it works is by installing @launchql/cli

npm install -g @launchql/cli
cd ./packages/ast
lql package

@pyramation pyramation merged commit 847e0de into launchql:master Jun 8, 2022
@pyramation
Copy link
Collaborator

Thanks for this awesome work @fljdin 🙌🏻

btw, I updated the package

@pyramation
Copy link
Collaborator

@fljdin I also want to show you that I added some tests in case you're interested:
https://github.com/pyramation/postgres-ast-deparser/blob/master/packages/ast/test/__tests__/sandbox/create-table.test.js

@pyramation
Copy link
Collaborator

pyramation commented Jun 14, 2022

@fljdin I updated the API to match the underlying call since cols implied columns only, and you can technically add indexes, etc.

you can see it here: 770b289

@fljdin fljdin deleted the 3-CreateStmt-with-tableElts branch June 30, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add columns definition for create_table() helper
2 participants