Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side bar not resizable when "Toggle Note list" is not selected (edited) #2865

Closed
techguybiswa opened this issue Mar 23, 2020 · 15 comments · Fixed by #2895
Closed

Side bar not resizable when "Toggle Note list" is not selected (edited) #2865

techguybiswa opened this issue Mar 23, 2020 · 15 comments · Fixed by #2895
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@techguybiswa
Copy link

techguybiswa commented Mar 23, 2020

DESCRIPTION

The Side Bar is not draggable in desktop when "Toggle Note List" is not selected

Environment

Joplin version: Joplin 1.0.195 (prod, darwin)
Platform: Desktop
OS specifics: macOS MOJAVE 10.14 , Win10 Pro x64 , Linux Mint 19.3 x64

EDIT
Actually the issue of not being able to resize the sidebar appears specifically when the "Toggle Note List" is not selected.

Steps to reproduce (edited)

  1. Open Joplin desktop app.
  2. Create a few Notebooks
  3. Make sure "Toggle Note List" is turned off.
  4. Try resizing the sidebar.

Describe what you expected to happen

  1. The sidebar should be resizable on drag even when "Toggle Note List" is not selected.
@techguybiswa techguybiswa added the bug It's a bug label Mar 23, 2020
@dpoulton-github
Copy link

Or the width of the sidebar should be draggable

That seems odd because on both the Windows and Linux platforms it is draggable.

@techguybiswa
Copy link
Author

Yeah, but in the environment, I mentioned the issue persists.
I restarted the app but even then I cannot get any option to drag it.

@coderrsid
Copy link
Contributor

Or the width of the sidebar should be draggable

It is scrollable on macOS. I can confirm that but it is indeed behaving weirdly. You can see below in the GIF.

Screen-Recording-2020-03-23-at-1

@techguybiswa
Copy link
Author

techguybiswa commented Mar 23, 2020

@coderrsid please click on the "Toggle Note List" and then try resizing it.
Check my screen recording at: https://gifyu.com/image/dxir

@coderrsid
Copy link
Contributor

Yes, that's an issue there. Please mention it too in the description of issue.

@techguybiswa
Copy link
Author

Yes, actually in my case the "Toggle Note LIst" was unselected by default and hence I could not figure out when it is working and when it is not.
Now that I understand it, I am updating the issue.
Thanks @coderrsid for pointing it out.

@coderrsid
Copy link
Contributor

Are you willing to fix the issue too? because i can look into the fix too.

@techguybiswa
Copy link
Author

@dpoulton-github can you please try in your Linux and windows environment to unselect "Toggle Note List" and then try to drag and see if it works or not?

@techguybiswa
Copy link
Author

Are you willing to fix the issue too? because i can look into the fix too.

Yeah sure go ahead and try to fix it. I am currently having some issues with running Joplin from the source code. (https://discourse.joplinapp.org/t/npm-start-throws-uncaught-error/7267/7)

@dpoulton-github
Copy link

dpoulton-github commented Mar 23, 2020

@dpoulton-github can you please try in your Linux and windows environment to unselect "Toggle Note List" and then try to drag and see if it works or not?

Joplin Desktop 1.0.195 - Tried on Win10 Pro x64 and Linux Mint 19.3 x64 and toggling the note list off prevents the sidebar from being adjusted.

@techguybiswa
Copy link
Author

@dpoulton-github can you please try in your Linux and windows environment to unselect "Toggle Note List" and then try to drag and see if it works or not?

Joplin Desktop 1.0.195 - Tried on Win10 Pro x64 and Linux Mint 19.3 x64 and toggling the note list off prevents the sidebar from being adjusted.

Thanks for the update.
I am editing the issue accordingly.

@techguybiswa techguybiswa changed the title Longer titles are not visible fully Side bar not resizable when "Toggle Note list" is selected Mar 23, 2020
@techguybiswa techguybiswa changed the title Side bar not resizable when "Toggle Note list" is selected Side bar not resizable when "Toggle Note list" is selected (edited) Mar 23, 2020
@techguybiswa techguybiswa changed the title Side bar not resizable when "Toggle Note list" is selected (edited) Side bar not resizable when "Toggle Note list" is not selected (edited) Mar 23, 2020
@techguybiswa
Copy link
Author

Yes, that's an issue there. Please mention it too in the description of issue.

Hi, I have updated the issue. Seems like the entire description and the title had to be edited.
Let me know if you have any more edits to suggest.

@anihm136
Copy link
Contributor

@coderrsid Are you working on this? If not, I'd like to try it

@coderrsid
Copy link
Contributor

I am working on some other issue. But i looked into it, the draggable property of sidebar is true all the time though. I didn't try to go deeper. You can go for it

@stale
Copy link

stale bot commented May 8, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label May 8, 2020
laurent22 added a commit that referenced this issue May 15, 2020
…splayed (#2895)

Co-authored-by: Laurent Cozic <laurent22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants