Desktop: Fixes #4658: Added a copy button and prevented showing default context menu

[xUser5000]

Description

This is a quick but not long-term fix to the issue #4658.
@roman-r-m @laurent22 @CalebJohn

What has been done

• Added a copy button next to the ID field.
• Prevented showing the default context menu when right-clicking on the ID value.

Screenshot

Things to notice

const { clipboard } = require('electron');
.
.
.

clipboard.writeText(value);

This is by no means the best way to implement the functionality and there should be some sort of abstraction that hides away the details of electron clipboard object. I very much encourage people who have more knowledge to modify this. However, in the meantime, this is the quickest way to do it.

Possible improvements

• Add a tooltip to the copy button for a better user experience.
• Add a small dialog that indicates the text has been copied successfully.

[laurent22]

Well we don't do "quick fixes" in this app :) Unless maybe for critical urgent bugs, and this one is not.

That being said the button you've added is useful so let's keep that. Please revert the changes to the text field (disabling the context menu) as it's not necessary. Now there's two way to copy the ID - Ctrl/Cmd+C (when it works) and your button, which is more than enough.

[xUser5000]

@laurent22
I did as you just said and reverted the last commit. Is it ready to be merged now ?

[laurent22]

Looks good now, thank you.

[tessus]

Sorry for resurrecting this thread, but I only noticed this now.

Any chance there could be some sort of feedback when clicking the icon?

Usually the icon flashes or there's some other feedback that the text was copied, but when clicking it nothing of that sort happens. Yes, the id is copied into the clipboard, but you don't know unless you check your clipboard.

Maybe this is not necessary, but it felt a bit weird.

And the context menu is still shown:

I can still use Cmd+C to copy the id, but the context menu has it greyed out.

[xUser5000]

@tessus
I'm sorry, this is the first time I noticed your comment. I guess I should change the notifications settings a bit then 😅
Regarding your suggestion about the copy feedback, I was thinking about that at the beginning and decided it would be cool If I added that. However, I don't know why, but I forgot to work on it. So, can I start working on it now ?

On the other hand, regarding the context menu, @laurent22 said to leave it without modifications just for now. It is also possible for other developers to work on it.