Desktop: Show installed plugins in Help - About Joplin

[roman-r-m]

• The list of plugin should appear within the About box.
• When clicking on "Copy", that list should be included too.
• If there are more than 20 plugins, just add "..." in the About box, but still make sure that all the plugins are copied when pressing "Copy". Also please check that the dialog is not broken when there are 20 plugins.

[Aman-Mandal]

Hey..can I take this issue?

[roman-r-m]

go for it

[Aman-Mandal]

Actually am very new in this.. can you tell me what exactly I need to do ? I would be glad if you can help
Thankyouuuu

[roman-r-m]

On high level:

• Check out the code
• Make sure you can build the app
• Start it, find the dialog
• Find in the code where it's created; see how it's populated
• Find the class that keeps track of installed plugins
• Access this class from the place where the dialog is populated, get the list of plugins, and display them

[tessus]

Was this discussed on the forum? If so, please add the link in the description.
Some people use many plugins (20+). I think it would mess up the About dialog. But maybe not.

I'd rather go for something similar to Synchronisation Status.

[roman-r-m]

I sent a message to Laurent and we was fine with it.

But I see your point - I assumed this dialog is just like every other view and the list could be made scrollable. But now having looked at how it's done I am no longer sure.

The idea was that often when someone reports an issue the 1st question is "what plugins do you have". If we could add this info to the version it should save some time.

[tessus]

I totally understand the reasoning behind it. I think it makes sense to put it in the About dialog or at least add the installed plugins, when you click the Copy button. I am just afraid it messes up the About dialog when a lot of plugins are used.

We can always add a Copy button to a window like Synchronisation Status. So, in case it messes up the About dialog, creating a separate menu item Installed plugins with a Copy button would do the trick.

[roman-r-m]

add the installed plugins, when you click the Copy button

This is what Android Studio does. I agree this makes more sense.

I suggest when someone implements this we have a look and if it does indeed messes up the dialog we can ask to implement only the copy - the difference between the 2 approaches looks to be trivial.

[Daeraxa]

Could the list of plugins just be within a scrollable frame within the main about dialogue box? (I'm sure there is a technical term for what I mean). This actually is how software I use at work displays installed drivers which can easily exceed 100 on some systems.

[roman-r-m]

From a quick look I think that dialog only supports plain text

[ahsenkamal]

I'd love to help ... is it assigned or I could still work on it?

[roman-r-m]

I'd love to help ... is it assigned or I could still work on it?

If you read the comments above, you'll see that Aman-Mandal was going to work on it.

[ahsenkamal]

If you read the comments above, you'll see that Aman-Mandal was going to work on it.

I'm new to all this, does it mean that I can not do anything related to this issue now?

[roman-r-m]

I'm new to all this, does it mean that I can not do anything related to this issue now?

Well you can, it just may not be the most useful thing as someone else has already starting working on this and may be first to submit a PR.

[ahsenkamal]

Well you can, it just may not be the most useful thing as someone else has already starting working on this and may be first to submit a PR.

Okay thanks

[Aman-Mandal]

If you read the comments above, you'll see that Aman-Mandal was going to work on it.

I'm new to all this, does it mean that I can not do anything related to this issue now?

Hey you can go ahead.. am sorry , am unable to solve this issue

[rookieCoder9]

Is this issue still available? If yes, I would like to fix it! I have read the above comments. What is the expected outcome - scrollable frame or ... followed by a few plugins?

[Daeraxa]

Have you read the closed PR that is linked just above your comment? There are comments in there and things you need to be aware of.
Otherwise yes, the issue/enhancement is still active as it has not been closed.
This other PR too - #6201

[rookieCoder9]

Yeah, I have already read that and the problems with that commit. I always comment after reading the above discussion! But it is always good to first ask the moderator before working on the issue. Let me go through it.
But still, the expected outcome isn't clear ? Will there be a scrollable area to display all plugins?

[Daeraxa]

The goal is in the issue text:

If there are more than 20 plugins, just add "..." in the About box, but still make sure that all the plugins are copied when pressing "Copy". Also please check that the dialog is not broken when there are 20 plugins.

There are other comments pointing out that the popup being used doesn't support anything beyond plain text so I don't think scrolling is even an option.

[rookieCoder9]

Hey, I have fixed my issue locally but don't know how to write unit tests. Can someone help me how to write unit tests?

Below I am attaching ss.
The first two are with around 17 plugins installed. The next ones are with 34 plugins installed. Last is with 20 Plugins installed. Please give feedback.

[Daeraxa]

There is newly (as in the last few days) updated documentation on test units so make sure you read that: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md#automated-tests

[rookieCoder9]

Thanks, I will go through it and will soon raise PR :)

[rookieCoder9]

Hey, I am still not getting how to add tests for this bug fix . Please help!

I have read the documentation of Jest but couldn't find a suitable test for this bug fix.

[Daeraxa]

To start with this is an enhancement, not a bug fix so therefore tests are even more critical that they are included.

If you want to ask specific questions about how to do something like that then I would advise asking in the forum development category but you won't get anywhere just asking "how to I do it" because that is a vital part of the challenge of adding a feature or creating a fix that you need to overcome. You at the very least need to demonstrate specifically what you are stuck on and what you have already done.

Otherwise you should look at other merged PRs and see how they have implemented tests so you can understand what you need to do.

[rookieCoder9]

Ok, thanks I will ask my doubts in the forum. Further, I will look at the previous merged PRs tests.

[mirchandani-mohnish]

@rookieCoder9 , are you done with the tests or are nearing the end given that you have not made a pull request. Can I help in any way?

[rajdama]

I am not able to see the installed plugins in the dialog box.

[Daeraxa]

I am not able to see the installed plugins in the dialog box.

There is no merged PR for this and you are running prod so this is entirely expected.

[rajdama]

I am not able to see the installed plugins in the dialog box.

There is no merged PR for this and you are running prod so this is entirely expected.

I am not able to see the installed plugins in the dialog box.

There is no merged PR for this and you are running prod so this is entirely expected.

What you mean by prod I didn't understood

[Daeraxa]

Literally in your screenshot (prod, win32) i.e. a "full" release version of Joplin.
You aren't running a dev version with somebody else's commit to add the plugins it and it obviously wouldn't contain your own code to fix it so I'm not sure what you are expecting to see. This entire issue exists to add the plugins list to the box.

[rajdama]

Literally in your screenshot (prod, win32) i.e. a "full" release version of Joplin. You aren't running a dev version with somebody else's commit to add the plugins it and it obviously wouldn't contain your own code to fix it so I'm not sure what you are expecting to see. This entire issue exists to add the plugins list to the box.

Ok I got it