Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Add share menu #876

Closed
chrootlogin opened this issue Oct 10, 2018 · 37 comments
Closed

Mobile - Add share menu #876

chrootlogin opened this issue Oct 10, 2018 · 37 comments
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements mobile All mobile platforms

Comments

@chrootlogin
Copy link

Allow the sharing of pictures and links to Joplin Mobile.

Operating system

  • iOS

Application

  • Mobile
@foxmask
Copy link
Contributor

foxmask commented Oct 10, 2018

which sharing of links ? because with android you can use the built-in share options and the URL of the webpage will be added to joplin.
Can't you do the same with iOS ?

@chrootlogin
Copy link
Author

Nope, I can't share things on iOS to Joplin. Tested with Safari Browser and the Photos App.

@elasticfusion
Copy link

Agreed. you can share "from" Joplin but not "to" Joplin directly. By that I mean the Joplin app is nowhere to be found on "Activities" menu.

img_0178

There are workarounds

. For example, there is a tight integration for photos:

  • Share Photo

However, for other content links to web content, you are left with a clunky copy and paste exercise. Hope this helps.

@foxmask foxmask added the mobile All mobile platforms label Oct 15, 2018
@CalebJohn
Copy link
Collaborator

CalebJohn commented Oct 15, 2018

As a note for anyone looking to implement this. The android side of things is implemented with react-native-share-extension, it also supports ios but you need the ios dev tools to actual implement it. From the joplin side the code is cross platform you'll just need to remove an os check at root.js line 541 and note.js line 241

edit: This is no longer true, this library doesn't work anymore and we now use a simpler implementation.

@ufulu
Copy link

ufulu commented Nov 20, 2018

I would like to bump this feature implementation, as this is the only drawback i have from using this awesome tool on a daily basis. thanks in advance for all your great work!

@aritrakoley
Copy link

Sharing to Joplin from browsers:
In Android, sharing to Joplin from the Chrome browser just copies the url to a new note. It would be helpful if some details of the shared webpage were added to the note. For example, the title of the page, if possible, a screenshot, or summary, etc.
Sharing of other media:
Even if not for audio and video, a feature to share images to Joplin as notes should be a priority.

@CalebJohn
Copy link
Collaborator

Sharing is a fairly complicated os specific detail, and because of this Joplin uses a library to handle it. Unfortunately that library is fairly buggy and can't currently support those extra features. But we have our eye on it and will update when possible.

@stale
Copy link

stale bot commented Sep 21, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Sep 21, 2019
@stale
Copy link

stale bot commented Sep 28, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Sep 28, 2019
@CalebJohn
Copy link
Collaborator

I think this should be re-opened, I don't think we have sharing on iOS yet.

@laurent22 laurent22 reopened this Oct 11, 2019
@stale stale bot removed the stale An issue that hasn't been active for a while... label Oct 11, 2019
@rallek
Copy link

rallek commented Oct 12, 2019

Sharing on Android works. But it can be improved. There are only the markdown of an picture is transfered not the picture itself.

@jareware
Copy link

Was expecting to be able to share on iOS; would be a supremely useful addition!

@tatoosh
Copy link

tatoosh commented Jan 2, 2020

this woud be a killer feature. all other notes app still can release this.
or is there a workaround?

@Aaryan-kapur
Copy link

Can I start working on this for my GSOC 2020 application!

@CalebJohn
Copy link
Collaborator

Of course, fair warning this is a fairly difficult feature so you may not make any large progress before the application deadline.

@Aaryan-kapur
Copy link

@CalebJohn thank you so much for the opportunity!
could you please assign me!

@stale
Copy link

stale bot commented May 9, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added stale An issue that hasn't been active for a while... and removed stale An issue that hasn't been active for a while... labels May 9, 2020
@CalebJohn
Copy link
Collaborator

Not stale

@stale
Copy link

stale bot commented Jun 23, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Jun 23, 2020
@CalebJohn
Copy link
Collaborator

CalebJohn commented Jun 23, 2020

Not stale

@stale stale bot removed the stale An issue that hasn't been active for a while... label Jun 23, 2020
@CalebJohn CalebJohn added the enhancement Feature requests and code enhancements label Jun 23, 2020
@laurent22 laurent22 added the backlog We'll get to it... eventually... label Jun 23, 2020
@Aaryan-kapur
Copy link

Hey @CalebJohn I had applied for this problem as my GSOC Project, but unfortunately I didn’t make it! Can I collaborate with the student selected for this particular project??

@CalebJohn
Copy link
Collaborator

Hi @Aaryan-kapur , unfortunately we didn't get as many slots as we initially wanted so this project did not get a student. You are free to start looking into adding ios sharing support, but I would suggest you work on something easier while you build up confidence.

@Aaryan-kapur
Copy link

Thanks for the guidance! @CalebJohn, I will start looking into other problems too, and start working on this task too!
could you please assign me?

@blizzrdof77
Copy link

blizzrdof77 commented Aug 12, 2020

Thanks for the guidance! @CalebJohn, I will start looking into other problems too, and start working on this task too!
could you please assign me?

👆 _😀 __👍 Hi @CalebJohn -- Did you guys get this sorted out already? Otherwise, it sounds like @Aaryan-kapur wants to take a swing at it!

@CalebJohn
Copy link
Collaborator

@blizzrdof77 we haven't from Aaryan since that last comment 2 months ago. It would be great if he can make this work but it doesn't look like it's being actively worked on.

@adamj-codethink
Copy link

+1

@CLSherrod
Copy link

I think this is the last item on my checklist of things that I need before I can switch from Evernote to Joplin.

@stephenhouser
Copy link

+1

1 similar comment
@cuiyuzhong
Copy link

+1

@Br3uxi
Copy link

Br3uxi commented Nov 6, 2020

Hello, I recently got into the IOS Ecosystem and already thought about diving a bit more into IOS Development, now I found Joplin and I also need this Feature. So I would love to help on this :)

@lighthousebulb
Copy link
Contributor

Sharing is a fairly complicated os specific detail, and because of this Joplin uses a library to handle it. Unfortunately that library is fairly buggy and can't currently support those extra features. But we have our eye on it and will update when possible.

@CalebJohn can you point out the used library? Are we able to push development on this?

@CalebJohn
Copy link
Collaborator

@lighthousebulb Joplin no longer uses the react-native-share-extension and instead has everything implemented natively for android. You can see the changes here. If you're interested in pushing this, go ahead! I'm sure a lot of IOS users would really appreciate it.

@harabat
Copy link

harabat commented Dec 17, 2020

+1

@benjypng
Copy link

benjypng commented Jan 7, 2021

+1 for this too.
I am extremely new to web development but would love to help out where I can.

@lighthousebulb
Copy link
Contributor

Awesome! Thank you! It got addressed in ios-v10.8.1. Now we have a working share-extension in iOS. Thanks!
This Issue might be closed now.

@lighthousebulb
Copy link
Contributor

Well... I'm missing the share-menu in Joplin ios-v-12.0.2 again.

@iFork
Copy link

iFork commented Jun 18, 2021

Well... I'm missing the share-menu in Joplin ios-v-12.0.2 again.

Try restarting iPhone. I encounter similar issues with some other app after its updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements mobile All mobile platforms
Projects
None yet
Development

No branches or pull requests