Desktop: Fixes #10685: Fix shift-delete asks to permanently delete the current note, rather than cut text, when the editor is selected. #10687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10685 by:
KeymapService
.permanentlyDeleteNote
from the global keyboard shortcuts.This also fixes an issue where shift-delete deleted notes to the trash, rather than permanently, when the note list was focused.
Note
This pull request targets
release-3.0
because I consider shift-delete no longer cutting text to be a regression.See 8c4aa7a for an alternate fix.
Comparison with 8c4aa7a
permanentlyDeleteNote
that works regardless of what has focus.Testing plan
This pull request contains an automated Playwright test that 1) delete a note permanently with shift-delete and 2) verifies that pressing shift-delete while the markdown editor is focused does not delete the current note.
It has also been verified (on Ubuntu 24.04) that: