Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for the great work that you've put into SlimerJS.
I couldn't be more excited when PDF rendering came out, unfortunately it does not honour width and height.
Looking at SlimerJS code, I realised it creates a print profile every time you render to PDF.
I have found all available print settings here: http://dxr.mozilla.org/mozilla-central/source/widget/nsIPrintSettings.idl
Having that said, I've tweaked the code to accept dimensions as well as ability to set margin and resolutions.
Dimensions must be passed as millimetres, and resolution in dpi.
This solves #162.
The options are:
Also, I've bumped to gecko 30.0. I've got some really heavy html that loads heaps of SVG. I believe previous versions had memory leaks, and randomly crashed with
Illegal instructions
andSegmentation Fault
. After updating, all errors have been solved apparently.Please instruct me if you require anything else for merging this pull request, and hope it helps other developers!
Cheers
@bernardeli