Affine hdf5 export (#221) #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test will fail, if a network consisting of an Affine layer cannot be
exported. This is the case, e.g., if the layer has no shape ('none'). In that
case, h5py will interpret it as an ('o') object, which is not supported by the
hdf5 format.
The shape of the Affine layer is set with respect to the output of the respective Dense layer. Previously this was 'None', resulting in an error while exporting to hdf5 due to being interpreted as object type by h5py. Now everything works due to being set to Float.
Currently, both tests are failing. This is due to 'l.394' of '/lib/dl/slayer/block/base.py' not being executed. This has to be fixed (?).
bamsumit
reviewed
Aug 17, 2023
|
@bamsumit I hope everything is fine now. Tests are passing on my machine! |
|
Hello @bamsumit , @PhilippPlank , is there still something to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #221
Objective of pull request:
A network consisting of an cuba.Affine layer cannot be exported to hd5f due to missing shape information. This is caused by h5py interpreting the missing shapes ('None') as object type ('O'), which is not supported by the hd5f format.
Enable to export the cuba.Affine() layer to hdf5 by inferring the shapes from the respective Dense layer. Additionally, a test was added.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
Cannot export cuba.Affine layer to hdf5.
What is the new behavior?
cuba.Affine layer can be exported to hdf5.
Does this introduce a breaking change?
Supplemental information