Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/feature yolo #243

Merged
merged 59 commits into from
Oct 17, 2023
Merged

Dev/feature yolo #243

merged 59 commits into from
Oct 17, 2023

Conversation

bamsumit
Copy link
Contributor

Issue Number: 242

Objective of pull request:
YOLO SDNN training and GPU inference pipeline

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit
Updated utils.py
d5c6749 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
elrond91 and others added 6 commits September 29, 2023 15:07
@elrond91
fixed inference notebook
7d32ac4 
Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@bamsumit
Factorized utils and metrics
1e8dffe 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Cleanup and finalizatio of the repo
a187034 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Added flake8 ignore for file
79553aa 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
network doc refactoring
e09084c 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Linting fix
a6bad3f 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit linked an issue Sep 30, 2023 that may be closed by this pull request
YOLO SDNN training #242
Closed
3 tasks
elrond91 and others added 11 commits October 2, 2023 08:59
@elrond91
fixed object detection dependencies libs
e4a538d
@elrond91
fixed cyclic imports
170a8c0
@elrond91
updated inference and bdd100 notebooks
6fb8891 
Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@elrond91
updated train_sdnn deps, need to formar file
11c0e1e 
Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@bamsumit
Polished inference notebook
16a0c9a 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
tweaks on inference notebook
c5317a8 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Dataset path cleanup
cee3564 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
inference notebook changes
a9b4932 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Merge branch 'main' into dev/feature-yolo
574d47b
@bamsumit
Updaed pyproject.toml
5f7319b 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated opencv requirement
fd4d140 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated poetry lock
9a65143 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
bamsumit and others added 11 commits October 4, 2023 04:38
@bamsumit
Linting errors fix
6c2ecba 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Added pretrained models
a08b6a3 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@elrond91
fixed bdd100k notebook
9941267 
Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@elrond91
fixed bdd100k notebook
f9f3c86 
Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@bamsumit
Added functionality to load pretrained models
5ddeb04 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
setup gitlfs track
ac44a63 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated inference notebook to use architecture of choice
81d2615 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Reduced animation size
8805e8a 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Fixed linting
6eabf5f 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Linting fixes
7bf4e7b 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated training readme
6bd0641 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Copy link
Contributor Author

bamsumit commented Oct 6, 2023

Dear Reviewers,

Do not fret seeing a lot of files in the PR. Here are the main files to be reviewed in the order of priority. Please :

  • tutorials/lava/lib/dl/slayer/tiny_yolo_sdnn/README.md
  • tutorials/lava/lib/dl/slayer/tiny_yolo_sdnn/train_sdnn.py
  • tutorials/lava/lib/dl/slayer/tiny_yolo_sdnn/inference.ipynb
  • src/lava/lib/dl/slayer/object_detection/models/tiny_yolov3_str.py
  • src/lava/lib/dl/slayer/object_detection/models/yolo_kp.py
  • src/lava/lib/dl/slayer/object_detection/boundingbox/metrics.py
  • src/lava/lib/dl/slayer/object_detection/boundingbox/utils.py
  • src/lava/lib/dl/slayer/object_detection/dataset/bdd100k.py
  • src/lava/lib/dl/slayer/loss.py
  • and the rest :)

elrond91 and others added 4 commits October 6, 2023 08:49
@elrond91
verification of training; added missing parameter; added extra result…
4071db6 
…s for model tiny_yolov3_str

Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@elrond91
verification of training; added missing parameter; added extra result…
81f3296 
…s for model tiny_yolov3_str

Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@elrond91
removed subset deps
f0e1790 
Signed-off-by: y <leobardo.e.campos.macias@intel.com>
@bamsumit
Updated training readme description
51e62ce 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
mgkwill
mgkwill approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places to remove commented code and a couple of comment spelling errors, else LGTM.

src/lava/lib/dl/slayer/object_detection/boundingbox/utils.py Show resolved Hide resolved
src/lava/lib/dl/slayer/object_detection/dataset/bdd100k.py Outdated Show resolved Hide resolved
src/lava/lib/dl/slayer/object_detection/models/Trained_tiny_yolov3_str/.gitattributes Show resolved Hide resolved
src/lava/lib/dl/slayer/object_detection/yolo_base.py Outdated Show resolved Hide resolved
src/lava/lib/dl/slayer/object_detection/yolo_base.py Outdated Show resolved Hide resolved
@Gavinator98 Gavinator98 mentioned this pull request Oct 16, 2023
Closed
@bamsumit
Fixed review comments
850d4e7 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated network inference
0fa7d5c 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated animation save
5cbbab7 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Updated args.txt
fefe57f 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit merged commit cfbcb25 into lava-nc:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgkwill mgkwill mgkwill approved these changes

@awintel awintel Awaiting requested review from awintel

@tim-shea tim-shea Awaiting requested review from tim-shea

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

@joyeshmishra joyeshmishra Awaiting requested review from joyeshmishra

@drager-intel drager-intel Awaiting requested review from drager-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YOLO SDNN training
3 participants
@bamsumit @mgkwill @elrond91