Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion tracking demo using bokeh for live visualization #71

Merged
merged 15 commits into from
Sep 19, 2023

Conversation

PhilippPlank
Copy link
Contributor

@PhilippPlank PhilippPlank commented Aug 31, 2023

Issue Number: #70

Objective of pull request: Add motion tracking demo which uses bokeh for live visualization.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank self-assigned this Aug 31, 2023
@PhilippPlank PhilippPlank linked an issue Aug 31, 2023 that may be closed by this pull request
8 tasks
@PhilippPlank PhilippPlank added the 1-feature New feature or request label Aug 31, 2023
Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and questions.

My main concern: how are we dealing with new software dependencies? I saw at least dv and bokeh.

demos/motion_tracking/dvs_file_input/process.py Outdated Show resolved Hide resolved
demos/motion_tracking/main_motion_tracking.py Outdated Show resolved Hide resolved
demos/motion_tracking/main_motion_tracking.py Outdated Show resolved Hide resolved
demos/motion_tracking/main_motion_tracking.py Outdated Show resolved Hide resolved
demos/motion_tracking/motion_tracking_network.py Outdated Show resolved Hide resolved
demos/motion_tracking/motion_tracking_network.py Outdated Show resolved Hide resolved
demos/motion_tracking/process_out/process.py Show resolved Hide resolved
demos/motion_tracking/process_out/process.py Outdated Show resolved Hide resolved
demos/motion_tracking/process_out/process.py Outdated Show resolved Hide resolved
demos/motion_tracking/Readme.md Outdated Show resolved Hide resolved
demos/motion_tracking/Readme.md Outdated Show resolved Hide resolved
demos/motion_tracking/Readme.md Outdated Show resolved Hide resolved
@PhilippPlank PhilippPlank merged commit d5be705 into main Sep 19, 2023
5 checks passed
@PhilippPlank PhilippPlank deleted the bokeh_demo branch September 19, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Motion Tracking into main of lava-dnf
4 participants