Virtual ports on multiple incoming connections #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnections of a port (wip). Signed-off-by: Mathis Richter <mathis.richter@intel.com>
PhilippPlank
requested changes
Mar 10, 2022
joyeshmishra
approved these changes
Mar 10, 2022
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
PhilippPlank
approved these changes
Mar 11, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Draft implementation to support virtual ports on multiple incoming connections of a port (wip). Signed-off-by: Mathis Richter <mathis.richter@intel.com> * Support for virtual ports on multiple incoming connections to PyPorts. Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft implementation to support virtual ports on multiple incoming connections of a port (wip).
This currently only supports this use case between PyOutPorts and PyInPorts (with virtual ports). RefPorts/VarPorts would have to be handled similarly.
I am looking for feedback on the way I am associating the CSP ports in the PyInPort with the transformation functions that must be applied. In the Compiler, I am associating the transformation functions with a string-based ID of the source port. In the Runtime, I am associating the CSP port with the same ID. The Builder is the only place where these two pieces of information coexist. There, I am then creating an association between the CSP port and the transformation function (through the common ID).
Signed-off-by: Mathis Richter mathis.richter@intel.com
Issue Number: #223
Objective of pull request: Support for virtual ports on multiple incoming connections to a Port.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information