Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the explicit ordering of subcompilers in compilation stack: C-first-Nc-second #408

Merged
merged 1 commit into from Oct 11, 2022

Conversation

srrisbud
Copy link
Contributor

Signed-off-by: Risbud, Sumedh sumedh.risbud@intel.com

Objective of pull request: Fixes issue first uncovered by lava-optimization test case. CProcCompiler is called before NcProcCompiler to correctly populate ports and channels.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

…irst-Nc-second heuristic

Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
@srrisbud srrisbud self-assigned this Oct 11, 2022
@ysingh7 ysingh7 merged commit 482bb0a into lava-nc:main Oct 11, 2022
@tim-shea tim-shea added this to the Release 0.5.1 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants