-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add probe for dds #667
Merged
hexu33
merged 8 commits into
lava-nc:messaging_refactor_release2nd
from
szc321:add_probe_for_dds
Apr 23, 2023
Merged
Add probe for dds #667
hexu33
merged 8 commits into
lava-nc:messaging_refactor_release2nd
from
szc321:add_probe_for_dds
Apr 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szc321 <zongcai.shi@intel.com>
Signed-off-by: szc321 <zongcai.shi@intel.com>
Signed-off-by: szc321 <zongcai.shi@intel.com>
Signed-off-by: szc321 <zongcai.shi@intel.com>
Signed-off-by: szc321 <zongcai.shi@intel.com>
Signed-off-by: szc321 <zongcai.shi@intel.com>
killight98
requested changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update py tests (test_channel.py
and test_all_delivery.py
) about dds.
src/lava/magma/runtime/_c_message_infrastructure/csrc/channel/dds/dds_channel.cc
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/csrc/channel/dds/dds_channel.cc
Outdated
Show resolved
Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/test/test_ddschannel.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: szc321 <zongcai.shi@intel.com>
hexu33
reviewed
Apr 21, 2023
src/lava/magma/runtime/_c_message_infrastructure/csrc/channel/dds/dds_channel.cc
Show resolved
Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/csrc/channel/dds/dds_channel.h
Show resolved
Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/csrc/core/channel_factory.cc
Show resolved
Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/csrc/message_infrastructure_py_wrapper.cc
Show resolved
Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/csrc/message_infrastructure_py_wrapper.cc
Show resolved
Hide resolved
Signed-off-by: szc321 <zongcai.shi@intel.com>
killight98
approved these changes
Apr 23, 2023
hexu33
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information