Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add probe for dds #667

Merged
merged 8 commits into from
Apr 23, 2023
Merged

Add probe for dds #667

merged 8 commits into from
Apr 23, 2023

Conversation

szc321
Copy link

@szc321 szc321 commented Apr 14, 2023

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@szc321
add_probe_for_dds
2d11f22 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321
clear log and fix lint
7d8a289 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321
amend test_ddschannel.cc
fb37914 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321
add default func
bd413f4 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321
add dds default constructor
172362b 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321
delete log
dbe47cb 
Signed-off-by: szc321 <zongcai.shi@intel.com>
killight98
killight98 requested changes Apr 19, 2023
View reviewed changes
Copy link

@killight98 killight98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update py tests (test_channel.py and test_all_delivery.py) about dds.

src/lava/magma/runtime/_c_message_infrastructure/csrc/channel/dds/dds_channel.cc Outdated Show resolved Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/csrc/channel/dds/dds_channel.cc Outdated Show resolved Hide resolved
src/lava/magma/runtime/_c_message_infrastructure/test/test_ddschannel.cc Outdated Show resolved Hide resolved
@szc321
move two dds constructors to wraper
7bd82a3 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@szc321
add explaination
c766fb0 
Signed-off-by: szc321 <zongcai.shi@intel.com>
@hexu33 hexu33 merged commit 0da8752 into lava-nc:messaging_refactor_release2nd Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killight98 killight98 killight98 approved these changes

@hexu33 hexu33 hexu33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szc321 @killight98 @hexu33