Commencement selected options fix #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longhotsummer
requested changes
Feb 10, 2022
| @@ -84,7 +84,9 @@ | |||
| // if we've selected all provisions, ensure we don't send back any selections | |||
| if (form.elements.all_provisions.checked) { | |||
| // we can't iterate over this in-place, so do this instead | |||
| while (form.elements.provisions.selectedOptions.length > 0) form.elements.provisions.selectedOptions[0].selected = false; | |||
| while ([...form.elements.provisions].some(provision => provision.checked)) { | |||
| form.elements.provisions[0].checked = false; | |||
There was a problem hiding this comment.
Almost... the goal of the original code is to uncheck everything when all_provisions is checked (it does the first element in selectedOptions only because selectedOptions slowly gets smaller and smaller.
The new code can just loop over all the elements and set checked to false on all of them.
…ecked uncheck all selections
longhotsummer
previously approved these changes
Feb 11, 2022
longhotsummer
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
form.elements.provisionsis aRadioNodeListform.elements.provisions.selectedOptionsis undefinedFix:
if
all_provisionsis checked uncheck allprovisionsresolves #1399