Work list facets #1872
Merged
Work list facets #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actlikewill
force-pushed
the
work-list-facets
branch
from
d8274c0
to
20e6fb8
Compare
it's unlikely actual work data will change within 30 seconds, whereas its common to click/unclick facets pretty quickly
|
@longhotsummer I have added the taxonomy and made the changes we discussed: https://www.loom.com/share/6a77b5aca43f4b8085476bc98f3e83e0?sid=8ee9a0b7-9f65-4ba3-8b21-f9ae4a424048 |
|
Looking great. Minor changes, please:
|
|
Oh and "Expression status" should be "Point in time status" |
- Document to Points in time - Expression status to Point in time
This reverts commit 2babd3e.
Advanced form tweaks
indigo_app/forms.py
Outdated
| @@ -387,6 +387,21 @@ class WorkFilterForm(forms.Form): | |||
|
|
|||
| advanced_filters = ['assent', 'publication', 'repeal', 'amendment', 'commencement', 'taxonomies', 'completeness'] | |||
|
|
|||
| # Principal | |||
| principal = forms.MultipleChoiceField(required=False, choices=[('principal', 'Principal'), ('not_principal', 'Not Principal'), ('stub', 'Stub'), ('not_stub', 'Not Stub')]) | |||
There was a problem hiding this comment.
I don't think the labels here have any reflection on reality, since the actual labels are driven by the facets calculation code.
longhotsummer
approved these changes
Nov 21, 2023
actlikewill
commented
Nov 21, 2023
indigo_app/forms.py
Outdated
| @@ -354,8 +354,8 @@ def data_as_url(self): | |||
|
|
|||
| class WorkFilterForm(forms.Form): | |||
| q = forms.CharField() | |||
| stub = forms.ChoiceField(choices=[('', 'Exclude stubs'), ('only', 'Only stubs'), ('temporary', 'Temporary stubs'), ('permanent', 'Permanent stubs'), ('all', 'Everything')]) | |||
| status = forms.ChoiceField(choices=[('published', 'published'), ('draft', 'draft')]) | |||
| stub = forms.MultipleChoiceField(choices=[('stub', 'Stub'), ('not_stub', 'Not stub'), ]) | |||
There was a problem hiding this comment.
note that we split out stubs into their own facet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facets for the new work list view:
https://www.loom.com/share/780e9445853045d39ae45880518ce696?sid=74a77e9f-d7dd-416f-a1c1-c6c0c6d805a0