Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include all doctypes in subtype filter #1879

Merged
merged 1 commit into from
Nov 23, 2023
Merged

include all doctypes in subtype filter #1879

merged 1 commit into from
Nov 23, 2023

Conversation

goose-life
Copy link
Contributor

This takes EXTRA_DOCTYPES per country into account

image image

longhotsummer
longhotsummer approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to change the model to always explicitly link to a FK doctype and a FK subtype, and to also store the textual frbr version of each. That's what we do in peachjam and it makes consistency and filtering far simpler, and would make this much simpler too.

@goose-life goose-life merged commit 47dc933 into work-list-v2 Nov 23, 2023
6 checks passed
@goose-life goose-life deleted the doctypes-subtypes branch November 23, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@actlikewill actlikewill actlikewill approved these changes

@longhotsummer longhotsummer longhotsummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goose-life @longhotsummer @actlikewill