Add Room Media API Calls #21
Conversation
| {}, | ||
| ) | ||
|
|
||
| async def getAudioDevices(self): |
There was a problem hiding this comment.
Could you document/provide an example of what kind of data format is returned by this call?
See here for an example:
pyControl4/pyControl4/account.py
Line 157 in 065485f
There was a problem hiding this comment.
The API call on OS 3.2.3, just returns None for me on both getAudioDevices/getVideoDevices. I do not make use of the functions in the HA integration instead we use the UI. Perhaps we delete these API Calls since they are not used?
There was a problem hiding this comment.
It returns None? Like literal Python None or some sort of valid JSON response that just says no devices?
I'm inclined to leave it in with a comment that says it returns none on OS 3.2.3 if it's actually a valid JSON response from Control4. Perhaps other configurations/older OS versions make use of this call.
There was a problem hiding this comment.
Yeah its just None the python literal. That is why I labeled as an invalid API call and deleted but I can put it back with comment that it wasn't valid in OS 3.2.3
There was a problem hiding this comment.
Done, I committed a change that brings back the functions and adds a warning note.
|
After we figure out that comment on |
|
Should I rebase and squash all commits together, or is this fine |
This is fine, it'll all be squashed by GitHub on merge |
Second Pull Request with Room API Calls authored by @nalin29