Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile won't work without manager.resolvers['curse'].folders_url #26

Closed
kurumushi opened this issue Oct 8, 2019 · 2 comments
Closed

Reconcile won't work without manager.resolvers['curse'].folders_url #26

kurumushi opened this issue Oct 8, 2019 · 2 comments

Comments

@kurumushi
Copy link

In commit 6881d81, you removed folders_url from the CurseResolver class. This is still needed for reconcile to work. Not sure if it's something in progress or a bug.
@layday
Copy link
Owner

layday commented Oct 8, 2019

Well, that's embarrassing (though reconcile does say it's untested on the tin cough).

@layday layday closed this as completed in 2ee8152 Oct 8, 2019
@layday
Copy link
Owner

layday commented Oct 8, 2019

Thanks again for the report.

layday added a commit that referenced this issue Nov 5, 2019
@layday
Restore URL required for reconcile to work
cc6b134 
High time I added some tests.

Closes #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kurumushi @layday