Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations to a section #5553

Closed
wants to merge 6 commits into from
Closed

Conversation

hargunkaur286
Copy link
Member

@hargunkaur286 hargunkaur286 commented May 30, 2024

Description

This PR fixes #5344

Notes for Reviewers
@sudhanshutech Can you have a look at it? I've added the animations.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
@l5io
Copy link
Contributor

l5io commented May 30, 2024

🚀 Preview for commit 92896ef at: https://6658beba8484c053f0e45c0c--layer5.netlify.app

@vishalvivekm
Copy link
Member

@hargunkaur286 Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you please exclude these ( package.json , package-lock.json) changes ?

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hargunkaur286 can you ensure this version change in package doesn't have any sideeffect. I am asking because sometimes some version include any other change in there dependencies

@sudhanshutech
Copy link
Member

animation looks good though to me. @leecalcote does this animation looks good to you?

@leecalcote
Copy link
Member

animation looks good though to me. @leecalcote does this animation looks good to you?

The new animations on the front page look really good, yes. I wonder if we can't add these same animations on the Solutions pages, too.

We have a winner here, @hargunkaur286! 🎈 🎉

@l5io
Copy link
Contributor

l5io commented Jun 8, 2024

🚀 Preview for commit eac28b2 at: https://6663acfeca7ec36060edea08--layer5.netlify.app

@hargunkaur286
Copy link
Member Author

@sudhanshutech Can you have a look now?

@sudhanshutech
Copy link
Member

lets see a last review today website call

@sudhanshutech
Copy link
Member

@hargunkaur286 why there is changes in package-lock.json if no change in package.json. If you have reverted any change also ensure you clear the package-lock.json module

Signed-off-by: Hargun Kaur <96698544+hargunkaur286@users.noreply.github.com>
@hargunkaur286
Copy link
Member Author

@sudhanshutech Can you have a look now?

@leecalcote
Copy link
Member

leecalcote commented Jun 19, 2024

@sudhanshutech is our vacation this week. @iArchitSharma can help, though.

@leecalcote leecalcote closed this Jun 19, 2024
@leecalcote leecalcote reopened this Jun 19, 2024
@sudhanshutech
Copy link
Member

@hargunkaur286 merge conflicts

@iArchitSharma
Copy link
Contributor

It's duplicate has been merged - #5633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Add animations to a section
6 participants