-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations to a section #5553
Animations to a section #5553
Conversation
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
🚀 Preview for commit 92896ef at: https://6658beba8484c053f0e45c0c--layer5.netlify.app |
@hargunkaur286 Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will you please exclude these ( package.json
, package-lock.json
) changes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hargunkaur286 can you ensure this version change in package doesn't have any sideeffect. I am asking because sometimes some version include any other change in there dependencies
animation looks good though to me. @leecalcote does this animation looks good to you? |
The new animations on the front page look really good, yes. I wonder if we can't add these same animations on the Solutions pages, too. We have a winner here, @hargunkaur286! 🎈 🎉 |
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
🚀 Preview for commit eac28b2 at: https://6663acfeca7ec36060edea08--layer5.netlify.app |
@sudhanshutech Can you have a look now? |
lets see a last review today website call |
@hargunkaur286 why there is changes in |
Signed-off-by: Hargun Kaur <96698544+hargunkaur286@users.noreply.github.com>
@sudhanshutech Can you have a look now? |
@sudhanshutech is our vacation this week. @iArchitSharma can help, though. |
@hargunkaur286 merge conflicts |
It's duplicate has been merged - #5633 |
Description
This PR fixes #5344
Notes for Reviewers
@sudhanshutech Can you have a look at it? I've added the animations.
Signed commits