Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improvement #2

Closed
robinheghan opened this issue Oct 23, 2015 · 2 comments
Closed

Suggestions for improvement #2

robinheghan opened this issue Oct 23, 2015 · 2 comments
Labels

Comments

@robinheghan
Copy link

Problems I stumbled onto when trying out this library:

Placing this in my project.clj file gave me an error: [com.layerware/hugsql "0.2.0"]
The error was something about not finding hugsql-core "0.1.0" in clojars if I remember correctly.

You should also note that hugsql uses io/resource to find sql files. My app crashed and I had no idea why, removing "resources" from the provided path-string solved the issue.

You should also probably have at least one execute (:!) example in the README. All your examples are currently select statements.

Other than that, great stuff!

@csummers csummers added the bug label Oct 23, 2015
@csummers
Copy link
Member

The hugsql-core 0.1.0 is definitely a bug leftover from a quick roll-out of 0.1.1. Thanks for the catch.

I'll look into the other issues. I might circle back for more detail on the io/resource issue. I agree about more examples with :execute.

Thanks!

csummers added a commit that referenced this issue Oct 23, 2015
@csummers
Copy link
Member

Fixed in 0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants