Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks on multiple lines of whitespace in sql file. #27

Closed
kvey opened this issue Mar 2, 2016 · 6 comments
Closed

Breaks on multiple lines of whitespace in sql file. #27

kvey opened this issue Mar 2, 2016 · 6 comments
Labels

Comments

@kvey
Copy link

kvey commented Mar 2, 2016

-- example

-- :name example-all :? :*
-- :doc Example
TABLE examples

Will succeed, while

-- example


-- :name example-all :? :*
-- :doc Example
TABLE examples

will fail with: clojure.lang.ExceptionInfo: Encountered SQL with no hugsql header line: 4, column: 1 {:line 4, :column 1}

@csummers
Copy link
Member

csummers commented Mar 2, 2016

@kvey I'm having trouble reproducing your issue using the "broken" example. What version of HugSQL are you using?

@kvey
Copy link
Author

kvey commented Mar 2, 2016

[com.layerware/hugsql "0.4.3"]

While loading from file using def-db-fns

@csummers
Copy link
Member

csummers commented Mar 2, 2016

Ok, so I was just now able to reproduce. Looks like a bug for sure. I'll find a fix and get it into the next release. Thanks for the report!

@csummers csummers added the bug label Mar 2, 2016
@kvey
Copy link
Author

kvey commented Mar 2, 2016

Sounds great! Thank you. (resolved for now in my current work by just adjusting all of that whitespace)

@csummers
Copy link
Member

csummers commented Mar 2, 2016

Found and fixed the issue. This will roll into 0.4.4 probably later today or tomorrow. Thanks again!

@csummers
Copy link
Member

csummers commented Mar 3, 2016

0.4.4 has been released with this fix. Please let me know if this has resolved the issue for you. Thanks!

@csummers csummers closed this as completed Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants