Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't read mgfs with upper cases in path #124

Closed
jens-decker-bruker opened this issue Mar 13, 2024 · 0 comments
Closed

Can't read mgfs with upper cases in path #124

jens-decker-bruker opened this issue Mar 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jens-decker-bruker
Copy link

Reading mgf files fails with a file not found error, if there is an upper case in the file name or somewhere in the path.

Should boil down to line 203 in main.rs where read_mgf is called with path_lower instead of
path like for the other file options:
sage_cloudpath::util::read_mgf(path_lower, file_id)
@lazear lazear added the bug Something isn't working label Mar 13, 2024
lazear added a commit that referenced this issue Mar 15, 2024
@lazear
fix: mgf paths were being lowercased (#124)
99407db
@lazear lazear closed this as completed Mar 15, 2024
jspaezp pushed a commit to jspaezp/sage that referenced this issue Mar 30, 2024
@lazear @jspaezp
fix: mgf paths were being lowercased (lazear#124)
82e8dbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazear @jens-decker-bruker