Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing precursor charge information #29

Closed
Tracked by #30
lazear opened this issue Oct 31, 2022 · 0 comments
Closed
Tracked by #30

Handle missing precursor charge information #29

lazear opened this issue Oct 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@lazear
Copy link
Owner

lazear commented Oct 31, 2022

It is possible to have precursors that are not annotated with charge state - Sage will currently panic/abort if these are found. A reasonable solution is to assume a charge state of 2/3/4, search all three charge states, and merge the results
@lazear lazear added the enhancement New feature or request label Oct 31, 2022
@lazear lazear mentioned this issue Nov 1, 2022
Closed
3 tasks
lazear added a commit that referenced this issue Nov 4, 2022
@lazear
Search MS2 spectra without charge states (#29)
b3f6a60
lazear added a commit that referenced this issue Nov 4, 2022
@lazear
Search MS2 spectra without charge states (#29)
9617404
@lazear lazear closed this as completed Nov 4, 2022
lazear added a commit that referenced this issue Nov 4, 2022
@lazear
Search MS2 spectra without charge states (#29)
6315c27 
- Enable env logging again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazear