Skip to content

Commit dfe161f

Browse files
authored
Dependency update (#24)
* updating windows install to setup everything and add to the env vars * updating git ignore * reformatting firefox test * updating dependencies
1 parent 9f6ac8b commit dfe161f

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
<dependency>
1414
<groupId>org.seleniumhq.selenium</groupId>
1515
<artifactId>selenium-java</artifactId>
16-
<version>3.0.1</version>
16+
<version>3.4.0</version>
1717
</dependency>
1818
<dependency>
1919
<groupId>org.testng</groupId>
2020
<artifactId>testng</artifactId>
21-
<version>6.10</version>
21+
<version>6.11</version>
2222
</dependency>
2323
</dependencies>
2424

@@ -28,7 +28,7 @@
2828
<plugin>
2929
<groupId>org.apache.maven.plugins</groupId>
3030
<artifactId>maven-surefire-plugin</artifactId>
31-
<version>2.19.1</version>
31+
<version>2.20</version>
3232
</plugin>
3333
<plugin>
3434
<groupId>org.eluder.coveralls</groupId>
@@ -41,7 +41,7 @@
4141
<plugin>
4242
<groupId>org.jacoco</groupId>
4343
<artifactId>jacoco-maven-plugin</artifactId>
44-
<version>0.7.7.201606060606</version>
44+
<version>0.7.9</version>
4545
<executions>
4646
<execution>
4747
<goals>

src/test/java/localbrowsers/Firefox.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,24 +23,24 @@ public class Firefox {
2323
public void firefoxSetup() {
2424
DesiredCapabilities capabilities = DesiredCapabilities.firefox();
2525
capabilities.setCapability("marionette", true);
26-
System.out.println(System.getProperty("os.name"));
27-
if(!System.getProperty("os.name").toLowerCase().contains("windows")){
28-
FirefoxBinary ff = new FirefoxBinary(new File("/Applications/Firefox.app/Contents/MacOS/firefox-bin"));
29-
FirefoxProfile ffp = new FirefoxProfile();
30-
31-
driver = new FirefoxDriver(ff, ffp, capabilities);}
32-
else{
26+
// mac requires the binary location to be set for firefox, not sure why at time of update
27+
if (System.getProperty("os.name").toLowerCase().contains("mac")) {
28+
FirefoxBinary ff = new FirefoxBinary(new File("/Applications/Firefox.app/Contents/MacOS/firefox-bin"));
29+
FirefoxProfile ffp = new FirefoxProfile();
30+
driver = new FirefoxDriver(ff, ffp, capabilities);
31+
} else {
3332
driver = new FirefoxDriver();
3433
}
3534
}
35+
3636
@Test
37-
public void test(){
37+
public void test() {
3838
driver.get("http://lazycoder.io/about.html");
3939
Assert.assertEquals(driver.getTitle(), "Lazy Coder Origins");
4040
}
4141

4242
@AfterTest
43-
public void testTeardown(){
43+
public void testTeardown() {
4444
driver.quit();
4545
}
4646
}

0 commit comments

Comments
 (0)