Add UndefinedBehaviorSanitizer to Linux CI #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UndefinedBehaviorSanitizer (a.k.a. UBSan) to the Linux CI job in addition to AddressSanitizer, which has already been added.
Also fix a couple uninitialized member variables that UBSan flagged. I am not sure if these are the correct default values to use, but they are at least better than uninitialized values. Even better would be if the classes could be refactored to always take in the value to initialize the variables with, but I will leave that to a future refactoring.
In case you're curious,
-fno-sanitize-recover=allis required because some UBSan checks are recoverable and do not terminate the process, but we want any violations to result in the CI failing.