avoid duplicate logic for bond price calculation #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lballabio
reviewed
Apr 6, 2020
| @@ -248,7 +248,10 @@ namespace QuantLib { | |||
|
|
|||
| FittedBondDiscountCurve::FittingMethod::FittingCost::FittingCost( | |||
| FittedBondDiscountCurve::FittingMethod* fittingMethod) | |||
| : fittingMethod_(fittingMethod) {} | |||
| : fittingMethod_(fittingMethod) { | |||
| for (Size i = 0; i < fittingMethod_->curve_->bondHelpers_.size(); ++i) | |||
There was a problem hiding this comment.
Maybe part of FittingMethod::init instead? Here it seems kind of hidden away to me...
There was a problem hiding this comment.
Yes. And I just noticed we can remove some more code there as well.
FittingCost::firstCashFlow_, which is actually not needed any more
|
Is the Travis CI job stuck? |
|
It finished successfully, but didn't signal back. I can merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.