Fix out of bound access in CalendarTest::testDayLists

[leonardoarcari]

This PR fixes an out of bound bug in CalendarTest::testDayLists.

Basically, no iterator-end-check was performed in

QuantLib/test-suite/calendars.cpp

Line 2203 in e6e81b2

if(d == *it_holidays && d == *it_businessDays) {

Therefore, when either it_holidays or it_businessDays reach end iterator, they're still dereferenced to be checked against d, hence yielding to undefined behavior.

This was detected by MSVC when compiling test-suite in debug mode.

[boring-cyborg]

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

[CLAassistant]

All committers have signed the CLA.

[coveralls]

Coverage remained the same at 71.071% when pulling 0128feb on leonardoarcari:master into e6e81b2 on lballabio:master.

[lballabio]

Hello! A suggestion: to keep the PR insulated from further changes you might make in your repo, you might consider opening it from a branch, and not from master. This way, further commits you do on master will not appear here.

[leonardoarcari]

Hello! A suggestion: to keep the PR insulated from further changes you might make in your repo, you might consider opening it from a branch, and not from master. This way, further commits you do on master will not appear here.

Yeah! 😆

I realized that I messed up the second I pushed another commit. I reset master branch to the point I opened this PR and moved all other changes to a dedicated branch. Thanks!

[boring-cyborg]

Congratulations on your first merged pull request!