Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reload #1242

Conversation

lbbrhzn
Copy link
Owner

@lbbrhzn lbbrhzn commented Jul 8, 2024

No description provided.

@lbbrhzn lbbrhzn had a problem deploying to continuous-integration July 8, 2024 09:00 — with GitHub Actions Failure
@drc38
Copy link
Collaborator

drc38 commented Jul 12, 2024

Hi @lbbrhzn,

Try changing:
assert await async_setup_entry(hass, config_entry)

with this:
assert await hass.config_entries.async_setup(config_entry.entry_id)

scruysberghs added a commit to scruysberghs/ocpp-1 that referenced this pull request Aug 5, 2024
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 12:37 — with GitHub Actions Failure
setup config entries through hass
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 12:54 — with GitHub Actions Failure
remove unused import
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 12:59 — with GitHub Actions Failure
use config_entries.async_remove
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 14:12 — with GitHub Actions Failure
@lbbrhzn
Copy link
Owner Author

lbbrhzn commented Aug 17, 2024

I think I should use config_entries.async_remove as well.

reintroduce async_reload_entry
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 14:21 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 14:29 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 14:32 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 14:41 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 14:52 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:17 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:19 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:23 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:29 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:32 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:34 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:36 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:38 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:42 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:44 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:48 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:49 — with GitHub Actions Failure
@lbbrhzn lbbrhzn had a problem deploying to continuous-integration August 17, 2024 15:52 — with GitHub Actions Failure
@lbbrhzn lbbrhzn temporarily deployed to continuous-integration August 17, 2024 15:52 — with GitHub Actions Inactive
@lbbrhzn lbbrhzn merged commit 724ba05 into dependabot/pip/pytest-homeassistant-custom-component-0.13.144 Aug 17, 2024
6 checks passed
@lbbrhzn lbbrhzn deleted the lbbrhzn-patch-4 branch August 17, 2024 15:56
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dependabot/pip/pytest-homeassistant-custom-component-0.13.144@4338d69). Learn more about missing BASE report.

Additional details and impacted files
@@                                       Coverage Diff                                        @@
##             dependabot/pip/pytest-homeassistant-custom-component-0.13.144    #1242   +/-   ##
================================================================================================
  Coverage                                                                 ?   91.06%           
================================================================================================
  Files                                                                    ?        9           
  Lines                                                                    ?     1377           
  Branches                                                                 ?      221           
================================================================================================
  Hits                                                                     ?     1254           
  Misses                                                                   ?       66           
  Partials                                                                 ?       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lbbrhzn added a commit that referenced this pull request Aug 17, 2024
… to 0.13.144 (#1236)

* build(deps): bump pytest-homeassistant-custom-component

Bumps [pytest-homeassistant-custom-component](https://github.com/MatthewFlamm/pytest-homeassistant-custom-component) from 0.13.136 to 0.13.144.
- [Release notes](https://github.com/MatthewFlamm/pytest-homeassistant-custom-component/releases)
- [Changelog](https://github.com/MatthewFlamm/pytest-homeassistant-custom-component/blob/master/CHANGELOG.md)
- [Commits](MatthewFlamm/pytest-homeassistant-custom-component@0.13.136...0.13.144)

---
updated-dependencies:
- dependency-name: pytest-homeassistant-custom-component
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* improve reload (#1242)

* improve reload

* Update test_charge_point.py

setup config entries through hass

* Update test_charge_point.py

remove unused import

* Update test_charge_point.py

use config_entries.async_remove

* Update __init__.py

reintroduce async_reload_entry

* Update test_charge_point.py

* Update __init__.py

* Update test_charge_point.py

* Update test_charge_point.py

* Update test_charge_point.py

* Update test_charge_point.py

* Update test_charge_point.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_init.py

* Update test_charge_point.py

* Update test_init.py

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: lbbrhzn <8673442+lbbrhzn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants